Merged
Conversation
MayRosenbaum
force-pushed
the
dynamic_reconfig_utils
branch
2 times, most recently
from
66f6113 to
6311754
Compare
There was a problem hiding this comment.
Pull request overview
This PR introduces helper utilities in the config package to support dynamic reconfiguration flows by deciding whether a node can apply a config update without an admin restart (and by detecting party eviction), plus a small helper to build a new Configuration from a config block.
Changes:
- Added
IsPartyEvicted/FindPartyhelpers for membership/eviction checks. - Added
IsNodeConfigChangeRestartRequiredto detect restart-required config changes (endpoint/TLS/sign cert). - Added
Configuration.BuildNewConfigurationand a new unit test file for the reconfig utilities.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 9 comments.
| File | Description |
|---|---|
| config/reconfig.go | New exported utility functions/interfaces for eviction detection and restart-required decisions. |
| config/reconfig_test.go | New tests for the reconfig utilities. |
| config/config.go | Adds BuildNewConfiguration helper to construct a new config from a config block. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
HagarMeir
reviewed
Feb 25, 2026
HagarMeir
reviewed
Feb 25, 2026
HagarMeir
reviewed
Feb 25, 2026
HagarMeir
reviewed
Feb 25, 2026
MayRosenbaum
force-pushed
the
dynamic_reconfig_utils
branch
from
0f26370 to
0c5aaea
Compare
tock-ibm
force-pushed
the
dynamic_reconfig_utils
branch
from
0c5aaea to
cc803de
Compare
tock-ibm
reviewed
Feb 26, 2026
Comment on lines
+39
to
+41
| // FindParty returns the PartyConfig associated with the given partyID from the shared configuration. | ||
| // It returns nil if the party is not found and returns error if the provided configuration is nil or incomplete. | ||
| func FindParty(partyID types.PartyID, config *Configuration) (*config_protos.PartyConfig, error) { |
Contributor
Author
There was a problem hiding this comment.
It will be used in the batcher
MayRosenbaum
force-pushed
the
dynamic_reconfig_utils
branch
from
cc803de to
872dab2
Compare
Signed-off-by: May.Buzaglo <May.Buzaglo@ibm.com>
Signed-off-by: May.Buzaglo <May.Buzaglo@ibm.com>
Signed-off-by: May.Buzaglo <May.Buzaglo@ibm.com>
tock-ibm
force-pushed
the
dynamic_reconfig_utils
branch
from
872dab2 to
66c1513
Compare
tock-ibm
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds utility functions to determine whether an admin restart is required.
Relevant issues #442 #504 #487 #445